tokens-studio / figma-plugin

Official repository of the plugin 'Tokens Studio for Figma' (Figma Tokens)
https://www.figma.com/community/plugin/843461159747178978
MIT License
1.32k stars 190 forks source link

Theme Switching With Styles [multi-dimensional] #2327

Open keeganedwin opened 8 months ago

keeganedwin commented 8 months ago

Describe the bug After releasing multi-dimensional themes, in the settings tab under the Prefix styles with active theme name feature we mention the following:

Note: Using this with multi-dimensional themes will lead to unexpected results.

So there is currently an issue with creating styles with a multi-dimensional setup and wanting to then theme switch. The way we achieved this before multi-dimensional is by creating let's say:

  1. Light mode in one library
  2. Dark mode in one library

Currently this does work in a singular dimension. So if you were to only create and publish the group with modes and enabled a mode in a third library it works, but it does not work with a multi-dimensional setup. So if you now add a brand group to this case it breaks. You can't get both the modes and themes to successfully switch and it's often the latter that causes an error with theme switching as it always overrides all frames to one brand instead of independently like with modes.

UdayHyma commented 2 months ago

Added to FeatureBase Roadmap- ❖ ❇️ Non-local support of variables and styles

SamIam4Hyma commented 2 months ago

Added to Featurebase Roadmap- 💚 Theme management enhancements - QOL