search

tokens-studio / figma-plugin

Official repository of the plugin 'Tokens Studio for Figma' (Figma Tokens)
https://www.figma.com/community/plugin/843461159747178978
MIT License
1.35k stars 194 forks source link

2820 lineheight variables not binding and applying with styles #2835

Closed robinhoodie0823 closed 3 months ago

robinhoodie0823 commented 3 months ago

Why does this PR exist?

Current plugin missed the logic to apply variables of typography property tokens like lineHeight, letterSpacing. It just applies token value.

Closes #2820

What does this pull request do?

Added a logic to applyTypographyTokenOnNode and tryApplyTypographyCompositeVariables functions to apply variables in case of typography property tokens.

Testing this change

Additional Notes (if any)

https://github.com/tokens-studio/figma-plugin/assets/103296157/c317f9b4-18c3-4576-aa1b-cd730c0e04d7

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 42ca842a42299965323d085df2050c021ef145ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR