tokens-studio / figma-plugin

Official repository of the plugin 'Tokens Studio for Figma' (Figma Tokens)
https://www.figma.com/community/plugin/843461159747178978
MIT License
1.32k stars 190 forks source link

fix: debug mode now shows `sessionId` #2869

Closed cuserox closed 2 weeks ago

cuserox commented 2 weeks ago

Why does this PR exist?

Closes #2772

At the bottom of the plugin Settings, a user can toggle the permission to record the session for debugging purposes. This was not showing the sessionId when turned ON!

What does this pull request do?

Doubts & further considerations

Testing this change

Before After
Screenshot 2024-06-18 at 14 07 24 Screenshot 2024-06-18 at 11 56 17
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 743e861e75a37bb3ad229447e11e7a47d2c5d93f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cuserox commented 2 weeks ago

Unsure of the sampling rates that we set when initialising Sentry as these are controlled by environment variables that get included in the pipeline (docs):

The Sentry -> Replays dashboard has entries. Tried to manually test locally, by setting all values to 1.0, but to no avail.

I have hope that this still works, but we should look to migrate and improve error handling as part of the DX epic.

six7 commented 2 weeks ago

Thank you!! 🎉