tokens-studio / figma-plugin

Official repository of the plugin 'Tokens Studio for Figma' (Figma Tokens)
https://www.figma.com/community/plugin/843461159747178978
MIT License
1.32k stars 190 forks source link

Revert manage theme followup #2889

Closed macintoshhelper closed 1 week ago

macintoshhelper commented 2 weeks ago

Why does this PR exist?

Resolve comments in #2883 Closes #2900

What does this pull request do?

Testing this change

  1. Click Theme: <Theme Name> then Manage themes >
  2. Try renaming a group and press Esc and confirm that the modal isn't closed
  3. Try renaming a group and check that the Cancel and Confirm buttons work correctly
  4. Click through into a theme, click the group name and click Create new group
  5. Confirm that pressing Esc doesn't close the modal
  6. Check that all locales are showing/resolving properly
  7. In the main modal screen, click to rename a group and confirm that the modal Close button works correctly and isn't blocked

Additional Notes (if any)

After

image
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: ae73ceb4a38cb3a8048324ba0b1364951e45887b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR