tokens-studio / figma-plugin

Official repository of the plugin 'Tokens Studio for Figma' (Figma Tokens)

https://www.figma.com/community/plugin/843461159747178978

MIT License

1.33k stars 191 forks source link

Deduplicate resolve modal fixes #2965

Open macintoshhelper opened 1 week ago

macintoshhelper commented 1 week ago

Why does this PR exist?

2779

What does this pull request do?

Move resolve duplicate warning button
Fix duplicate resolve modal copy

Testing this change

Switch to production version
Create a group with a conflicting/overlapping token name, but unique group name
Duplicate this new group to an existing group name, with an overlapping token
Switch back to this version
Check the icon button UI and the modal UI

Additional Notes (if any)

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 7105708af2fad8a9ddab3db5094127fbdb536002

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 week ago

Commit SHA:0bd505c4de03bfec7d8ef26aa83094897138f51a

Test coverage results :test_tube:

Code coverage diff between base branch:release-139 and head branch: fix/deduplicate-resolve-copy

Status	File	% Stmts	% Branch	% Funcs	% Lines
:red_circle:	total	67.29 (-0.01)	58.28 (0)	63.88 (0)	67.7 (0)
:green_circle:	packages/tokens-studio-for-figma/src/app/components/Footer.tsx	78.26 (7.21)	50 (4.55)	37.5 (-0.96)	85 (10.72)
:red_circle:	packages/tokens-studio-for-figma/src/app/components/TokensBottomBar.tsx	55.55 (5.55)	37.5 (-12.5)	42.85 (-7.15)	55.55 (5.55)

github-actions[bot] commented 1 week ago

Commit SHA:0bd505c4de03bfec7d8ef26aa83094897138f51a Current PR reduces the test coverage percentage by 1 for some tests