tokens-studio / figma-plugin

Official repository of the plugin 'Tokens Studio for Figma' (Figma Tokens)
https://www.figma.com/community/plugin/843461159747178978
MIT License
1.34k stars 194 forks source link

Add ability to define token type #650

Open chriskerr-performio opened 2 years ago

chriskerr-performio commented 2 years ago

Is your feature request related to a problem? Please describe. We tokenise our icons. This helps us swap out sets for white-labelling for our clients. They are semantic icons, so have specific meaning for use in components and in our application.

At the moment, we add these under the Other category, and in the generated JSON, the group value is set to "Other".

We also name our token grouping slightly differently to the plugin. For example, I'd prefer to call "Typography", "textStyle" (shorter, i don't mistype it as much 😆).

Describe the solution you'd like I'd also like to be able to customise the existing group values, overriding the defaults used today. Essentially expose this value in the token as populated, but editable field. Obviously this would benefit from broader bulk actions, but that's probably a seperate issue.

Describe alternatives you've considered Currently I generate the JSON in Figma Tokens, then edit the group values by hand. This is obviously frustrating as I have to do it every time I update the tokens.

Additional context None.

six7 commented 2 years ago

BTW You can just alter the type in the JSON, the plugin will respect that (until you save in the UI that is, which is an issue. But if all you need those tokens for is to have them stored for dev, then that'd work).

chriskerr-performio commented 2 years ago

Yep this is what i do today for all my custom token types. it'd be cool to be able to be able to create a custom name (aka type) in the UI at the top level grouping

More importantly though, if you do change Type in the JSON, in the UI when you edit a token within that custom group, the type reverts to Other, which is super annoying..... obviously ideal case is that the user entered value is retained on Edit/Save

six7 commented 2 years ago

Yep this is what i do today for all my custom token types. it'd be cool to be able to be able to create a custom name (aka type) in the UI at the top level grouping

More importantly though, if you do change Type in the JSON, in the UI when you edit a token within that custom group, the type reverts to Other, which is super annoying..... obviously ideal case is that the user entered value is retained on Edit/Save

💯 that is annoying. Added it to one of our upcoming iterations: https://github.com/six7/figma-tokens/issues/1202

chriskerr-performio commented 2 years ago

Awesome! Mike said he might see if we can squeeze this into a release candidate as I actually wanted to show this action in the Livestream on Thursday. If not, will just talk to it and not show it

On Sat, 20 Aug 2022 at 06:38, Jan Six @.***> wrote:

Yep this is what i do today for all my custom token types. it'd be cool to be able to be able to create a custom name (aka type) in the UI at the top level grouping

More importantly though, if you do change Type in the JSON, in the UI when you edit a token within that custom group, the type reverts to Other, which is super annoying..... obviously ideal case is that the user entered value is retained on Edit/Save

💯 that is annoying. Added it to one of our upcoming iterations: #1202 https://github.com/six7/figma-tokens/issues/1202

— Reply to this email directly, view it on GitHub https://github.com/six7/figma-tokens/issues/650#issuecomment-1221074878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYBWJFWSO26IIUKIC2N63XLVZ7WDRANCNFSM5UT23QZA . You are receiving this because you authored the thread.Message ID: @.***>

-- [image: Performio] https://www.performio.co Chris Kerr Principal Product Designer @.*** | ​ Performio Irvine | San Francisco | Melbourne | London

sir-captainmorgan21 commented 2 years ago

Is it a lot of work to add a "type" field for "Other" tokens? If type is left blank, set to other. Or are we thinking of adding the ability to add your own section, essentially removing the "other" group?

UdayHyma commented 4 months ago

Added to Featurebase Roadmap : 🪙 Expand token types