search

tokens-studio / sd-transforms

Custom transforms for Style-Dictionary, to work with Design Tokens that are exported from Tokens Studio
MIT License
194 stars 28 forks source link

Fix add-font-styles with italic weight that don't explicitly state they are regular #191

Closed thomasmattheussen closed 1 year ago

thomasmattheussen commented 1 year ago

Some fonts (such as Roboto) don't explicitly name their regular italic weight Regular Italic. (It's just named Italic instead of Regular Italic.)

Not sure how you'd like to handle this case, but I've already added a test case.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: e486d9460de055cc368d9d8e26da59cb72d0d0c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------- | ----- | | @tokens-studio/sd-transforms | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jorenbroekema commented 1 year ago

I think we can handle it like this, let me know what you think

thomasmattheussen commented 1 year ago

Looks good to me! 👍