tokens-studio / sd-transforms

Custom transforms for Style-Dictionary, to work with Design Tokens that are exported from Tokens Studio
MIT License
175 stars 27 forks source link

Add "book" to font weights #265

Closed nhoizey closed 4 months ago

nhoizey commented 4 months ago

We use the Sharp Sans font in our project, where we use Tokens Studio and Figma: https://sharptype.co/typefaces/sharp-sans/#specimen

Sharp Sans defines the 400 font-weight as Book, so that's what Figma uses.

Currently, sd-transforms transforms other font weights to numbers, but Book stays as is, which is not right.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 58f8bb5f1d6d4f5b91f71f42c914931a60036b62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------- | ----- | | @tokens-studio/sd-transforms | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jorenbroekema commented 4 months ago

Thanks! :) yeah we have "buch" already (German for book I think?) so imo makes sense to add English version of that.

Too bad there isn't a true standard for fontweight names, so we could run into issues where fonts do not agree on the names in the future, but we'll cross that bridge when/if we get there

nhoizey commented 4 months ago

yeah we have "buch" already (German for book I think?) so imo makes sense to add English version of that.

That's what I thought also, forgot to mention it. 😅

Too bad there isn't a true standard for fontweight names, so we could run into issues where fonts do not agree on the names in the future, but we'll cross that bridge when/if we get there

I agree.

It looks like some type foundries even use the same name for different weights… 😞