Closed nhoizey closed 4 months ago
Latest commit: 58f8bb5f1d6d4f5b91f71f42c914931a60036b62
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Thanks! :) yeah we have "buch" already (German for book I think?) so imo makes sense to add English version of that.
Too bad there isn't a true standard for fontweight names, so we could run into issues where fonts do not agree on the names in the future, but we'll cross that bridge when/if we get there
yeah we have "buch" already (German for book I think?) so imo makes sense to add English version of that.
That's what I thought also, forgot to mention it. 😅
Too bad there isn't a true standard for fontweight names, so we could run into issues where fonts do not agree on the names in the future, but we'll cross that bridge when/if we get there
I agree.
It looks like some type foundries even use the same name for different weights… 😞
We use the Sharp Sans font in our project, where we use Tokens Studio and Figma: https://sharptype.co/typefaces/sharp-sans/#specimen
Sharp Sans defines the 400 font-weight as
Book
, so that's what Figma uses.Currently,
sd-transforms
transforms other font weights to numbers, butBook
stays as is, which is not right.