search

tokens-studio / sd-transforms

Custom transforms for Style-Dictionary, to work with Design Tokens that are exported from Tokens Studio
MIT License
175 stars 27 forks source link

chore: small fix for platform config usage #295

Closed jorenbroekema closed 3 weeks ago

jorenbroekema commented 3 weeks ago

fixes some sloppiness I introduced here: https://github.com/tokens-studio/sd-transforms/pull/290

I wouldn't mind encapsulating platform config options inside an options property like we do for format-level options, it would be a bit more consistent.. But currently style-dictionary also doesn't do this for the platform config option "basePxFontSize" so doing it now would be inconsistent as well.

I think we should pull transform options passed through platform config into an "options" object though in the future but this would a small breaking change, so it will be style-dictionary v5. too bad I missed this for v4.

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: a78a542ad786c0daa0638c6e4f06a48bdf261713

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jorenbroekema commented 3 weeks ago

https://github.com/amzn/style-dictionary/issues/1266 raised this issue