Closed adamstankiewicz closed 1 month ago
Latest commit: 3220935818d7f01405bbd6cd28bc36c97cd5059a
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[inform] The changes in this PR are also included in a related proposed change: https://github.com/tokens-studio/sd-transforms/pull/313
If that one merges, this one may be closed. Otherwise, this can be its own standalone contribution, too :)
Thanks :)!
While exploring some of the transforms and their associated tests, I noticed the
init
function used to initializestyle-dictionary
(i.e., registersd-transforms
anddict.buildAllPlatforms()
) accepts an untyped function argumenttransformOpts
.This PR associates the
TransformOptions
type to thistransformOpts
argument.In doing so, TypeScript began throwing an error within
cross-file-refs.test.ts
that the existingexpand
option passed toinit
isn't valid per theTransformOptions
type. The tests pass regardless of whetherexpand
is present or not in the provided options, which seems to indicate nothing consumes the property value. As such, I've removedexpand
from this test suite.