search

tokers / zstd-nginx-module

Nginx modules for the Zstandard compression
BSD 2-Clause "Simplified" License
196 stars 23 forks source link

use of dynamic libzstd.so #12

Closed eilandert closed 9 months ago

eilandert commented 2 years ago

It should be possible to use a dynamic library (libzstd.so) instead of including the static libzstd.a into the module, it's a lot easier to maintain/upgrade libzstd.so when a new version comes out instead of recompiling nginx.

I tried to create PR but didn't succeed yet.

(this had nothing to do with compiling the dynamic modules for nginx)

dvershinin commented 1 year ago

@eilandert In its current state as long as libzstd.a isn't present on the system, it does the proper job of linking with the dynamic library:

ldd ./objs/ngx_http_zstd_filter_module.so 
    linux-vdso.so.1 (0x00007ffde71e7000)
    libzstd.so.1 => /lib64/libzstd.so.1 (0x00007ff5a6b07000)
    libc.so.6 => /lib64/libc.so.6 (0x00007ff5a6741000)
    /lib64/ld-linux-x86-64.so.2 (0x00007ff5a6faf000)