search

tokers / zstd-nginx-module

Nginx modules for the Zstandard compression
BSD 2-Clause "Simplified" License
196 stars 23 forks source link

Build fails with warnings enabled #27

Closed dvershinin closed 8 months ago

dvershinin commented 1 year ago 
        -o objs/ngx_http_zstd_static_module_modules.o \
        objs/ngx_http_zstd_static_module_modules.c
zstd-nginx-module-0.1.0/filter/ngx_http_zstd_filter_module.c: In function 'ngx_http_zstd_filter_create_cstream':
zstd-nginx-module-0.1.0/filter/ngx_http_zstd_filter_module.c:606:9: error: 'ZSTD_initCStream_usingCDict' is deprecated (declared at /usr/include/zstd.h:2530) [-Werror=deprecated-declarations]
         rc = ZSTD_initCStream_usingCDict(cstream, zlcf->dict);
         ^
cc1: all warnings being treated as errors
         ^

Fails to build the module on RHEL 7, 8, 9 if "warnings as errors" are enabled (the default). While it can be bypassed, RPM builds require more strict compilation settings.

dvershinin commented 8 months ago

Closing since this was fixed already