search

tokers / zstd-nginx-module

Nginx modules for the Zstandard compression
BSD 2-Clause "Simplified" License
196 stars 23 forks source link

Invalid module order #30

Closed JakubOnderka closed 7 months ago

JakubOnderka commented 8 months ago

Module order is incorrect for compression module. For example, if using ngx_http_sub_module, string is not replaced because it it tries to replace content when it is already compressed.

For inspiration you can check

https://github.com/google/ngx_brotli/blob/a71f9312c2deb28875acc7bacfdd5695a111aa53/filter/config#L70-L85

tokers commented 7 months ago

@JakubOnderka Got it, thanks!

tokers commented 7 months ago

@JakubOnderka The patch was merged and I'm going to close this issue now.