tokio-rs / async-stream

Asynchronous streams for Rust using async & await notation
Other
636 stars 33 forks source link

The scope of the unsafe block can be appropriately reduced #76

Closed peamaeq closed 2 years ago

peamaeq commented 2 years ago

In these function you use the unsafe keyword for almost the entrie function body. We need to mark unsafe operations more precisely using unsafe keyword. Keeping unsafe blocks small can bring many benefits. For example, when mistakes happen, we can locate any errors related to memory safety within an unsafe block. This is the balance between Safe and Unsafe Rust. The separation is designed to make using Safe Rust as ergonomic as possible, but requires extra effort and care when writing Unsafe Rust. Hope this PR can help you. Best regards. References https://doc.rust-lang.org/nomicon/safe-unsafe-meaning.html https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html