search

tokio-rs / axum

Ergonomic and modular web framework built with Tokio, Tower, and Hyper
19.03k stars 1.06k forks source link

Update prost to 0.13 #2829

Closed NOBLES5E closed 1 month ago

jplatte commented 3 months ago

There is an existing PR for this at #2825.

jplatte commented 3 months ago

Oh, sorry that's actually independent, just looked more closely 🤦🏼

NOBLES5E commented 3 months ago

Update Rust version to 1.70 to meet prost dependency requirements

However, I'm not certain if this change is appropriate for axum-extra

NOBLES5E commented 3 months ago

The CI doesn't seem to select the rust-version defined in individual crates though

jplatte commented 3 months ago

Feel free to just bump the MSRV defined in the workflow file. I don't think we'll be doing much more stuff for axum 0.7 anyways, and 0.8 will raise MSRV again.

NOBLES5E commented 3 months ago

Great. I've updated the MSRV in the workflow file to 1.70 as suggested.

ksanfs commented 3 months ago

I was wondering when the prost update might be included in a release? I completely understand if it's not possible to provide a specific timeline, but any general indication would be helpful for planning purposes on my end.

jplatte commented 3 months ago

This is likely to take at least another month, possibly many before it goes out. David hasn't been that active and I don't think it makes much sense to publish another breaking-change release of axum-extra before axum 0.8.

realtimetodie commented 3 months ago

I don't understand why this is not released yet. In the past, it took only a couple of hours to bump a new Prost version. Now it takes months, excuse me?

realtimetodie commented 3 months ago

@davidpdrsn could you take a look please, it's about bumping a new Prost version merci beaucoup

jplatte commented 3 months ago

Nobody is paid to work on axum, and priorities change. Also this is a breaking change and we haven't yet merged any breaking changes to main since 0.7.0.

There will likely be another set of releases, then we will start doing that. However, there's still a bunch of other things we want to do between merging this PR and releasing axum 0.8, axum-extra 0.10 (see the 0.8 milestone).

realtimetodie commented 3 months ago

Nobody is paid to work on axum, and priorities change.

Wow you know what, when I first introduced the Protobuf extractor and response in PR #1214 no one paid me either. If money is the primary concern for you, maybe you should quit programming.

Also there should be no problem to create a feature-branch, cherry-pick the PR and then to make a release. A major one even. Oh look, I did it for you and it.. just worked

axum-extra = { git = "https://github.com/realtimetodie/axum.git", branch = "prost-0.13", features = ["protobuf"] }