Remove ptr_map special casing for miri (#565)

tokio-rs / bytes

Utilities for working with bytes

MIT License

1.91k stars 288 forks source link

Remove ptr_map special casing for miri (#565) #630

Open shahn opened 1 year ago

shahn commented 1 year ago

Since Rust 1.65, which introduced LLVM 15, codegen for both versions of ptr_map is the same. The release happened in Nov 2022, which should mean the majority of users have upgraded.

seanmonstar commented 1 year ago

I wouldn't make this change until the MSRV was forced passed that version. And since this is just for tests, there isn't enough of a reason to force it.

shahn commented 1 year ago

Bumping MSRV for sure is not warranted for this change. I made this patch due to this: https://github.com/tokio-rs/bytes/issues/565#issuecomment-1214219588