search

tokio-rs / bytes

Utilities for working with bytes
MIT License
1.91k stars 288 forks source link

impl From<Box<[u8; _]>> for Bytes #631

Closed MarinPostma closed 1 year ago

MarinPostma commented 1 year ago

I found that this implementation was missing when I needed it.

Darksonn commented 1 year ago

Thanks for the PR. Unfortunately, const generics is not available on bytes's minimum supported Rust version.

MarinPostma commented 1 year ago

@Darksonn Do you think we can bump the msrv? 1.51 is from March 2021, which was over 2 years ago. Happy to open a PR to do that as well

MarinPostma commented 1 year ago

It's not a blocker though; there are ways around it, I just think it's an ergonomy improvement :)

Darksonn commented 1 year ago

Meh, I don't think this impl is enough justification to do that.