Currently, the console only supports TCP, is there a plan to support Unix Domain Socket?

tokio-rs / console

a debugger for async rust!

MIT License

3.61k stars 142 forks source link

Currently, the console only supports TCP, is there a plan to support Unix Domain Socket? #296

Closed quanweiZhou closed 1 year ago

hawkw commented 2 years ago

The console uses tonic as both the gRPC server (in the console-subscriber crate) and as the gRPC client (in the tokio-console command-line application). It looks like a PR to add Unix socket support in tonic was merged recently (https://github.com/hyperium/tonic/pull/861), but I don't believe it has been released yet. Once that PR is part of an upstream release of tonic, it should be pretty straightforward to add UDS support to the console.

Milo123459 commented 2 years ago

A new version was released 3 days ago, I believe that Unix socket support is in that release. Could this be looked at?

hawkw commented 2 years ago

Yes, once we merge #318, it should be pretty easy to add support for Unix sockets. I've been out of the office for the last four days, so I haven't had the time to take care of that until today.

Milo123459 commented 2 years ago

Cool! Glad to know it's hopefully getting implemented soon.

quanweiZhou commented 2 years ago

@hawkw Currently the tonic 0.7 already supports UDS but the console doesn't seem to support UDS yet, am I missing something?

Milo123459 commented 2 years ago

Any updates? #318 was merged.

hawkw commented 2 years ago

I haven't had the time to work on this, but now that Tonic 0.7 is out, it should certainly be possible and (I imagine) fairly straightforward. I'd happily merge a PR if anyone is interested in working on one.