Open goriunov opened 5 years ago
cc @jonhoo
I'm on my way out the door, and may not be able to get to this until after the weekend, but some brief thoughts:
main
that actually uses the LinesCodec
! This seems like a good separate issue we could track and mark with good-first-issue
:D
I have went through the sections in
io with tokio
and it looks really good. There are few things which i found slightly hard to track for new comers.In the first section
tokio io overview
we have an example which implementssocket.split();
andcopy
combinators and later on we get an explanation of that things but i think it would be great if i could see the same example but without using any combinators and directly useAsyncRead
andAsyncWrite
this will give a better overview forsplit
andcopy
and how it works.Shutdown documentation link from
Using AsyncRead and AsyncWrite directly
is wrong and would be good to have some example how to use it in the docs as well.Some examples are incomplete ex:
Transports
as i can not just copy and past code and play with that around. As it will not run withoutmain
function and for someone who is new to the tokio it will be a bit hard to complete code forLinesCodec
to run it properly. (it is also related to other examples)Thank you very much for your work :)