tokio-rs / io-uring

The `io_uring` library for Rust
Apache License 2.0
1.21k stars 134 forks source link

Add notif and related SendZc docs #299

Closed erenon closed 2 months ago

erenon commented 3 months ago
quininer commented 3 months ago

Can you add a test? and you don't need to add much docs, just point to manpage of IORING_OP_SEND_ZC.

erenon commented 3 months ago

Added a test. I have two issues with just linking the docs:

I find this doc+notif to be visible important, because without these, SendZc cannot be used correctly. If you feel strongly about keeping the doc minimal, I can of course replace the paragraph with a link, let me know.

quininer commented 3 months ago

I don't have the energy to keep track of upstream docs, so I prefer to keep minimal description and point to correct upstream docs.

erenon commented 3 months ago

Got it. Added a link instead of the text.

erenon commented 3 months ago

fmt fixed (extra newline removed)

quininer commented 2 months ago

Thank you!