tokio-rs / loom

Concurrency permutation testing tool for Rust.
MIT License
2.08k stars 110 forks source link

Fix drop order of tls and statics and avoid double panics on deadlock #297

Open Pointerbender opened 1 year ago

Pointerbender commented 1 year ago

Hello! I ran into some of the same issues as mentioned in #152, #179 and #291 and developed a fix for all of those issues. In a nutshell, the changes are:

This is my first time contributing to loom, please let me know if I can somehow improve this PR or if additional information is needed. Thank you!

Pointerbender commented 1 year ago

Hello! Just checking in to see if there is anything I can do to help shepherd this PR along. :) I'd be happy to provide extra details or hop on chat/zoom to review together if that saves some time. No rush, though!

hawkw commented 1 year ago

Thank you for working on this, this is great! I'll try to give it a review at some point soon, although I imagine @carllerche will want to as well.

Pointerbender commented 1 year ago

I've addressed the PR comments left by @adrianheine (thanks for the review!), are there any next steps left before this could potentially be merged? :) Please let me know if I can be of any further assistance. Thank you!