search

tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.69k stars 481 forks source link

chore: Split prost-types lib.rs into separate modules. #1007

Closed gibbz00 closed 4 months ago

gibbz00 commented 4 months ago

Protobuf JSON mapping requires a lot of custom serializing for each protobuf type. Continuing to add that logic in a huge lib.rs file would quickly make these things harder to maintain and reason about.

Depends on #1006

gibbz00 commented 4 months ago

Shit, rebased anyway after the LGTM, sorry. Pressed the rebase button on Github, nothing else.

caspermeijn commented 4 months ago

Shit, rebased anyway after the LGTM, sorry. Pressed the rebase button on Github, nothing else.

No problem. My first reaction was: it needs a rebase. My second reaction was: well, GitHub will do that automatically.

gibbz00 commented 4 months ago

Hehe. It do be like that sometimes. Thanks 😊