search

tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.69k stars 481 forks source link

prost-build: Split `Config` into a separate module and file. #1015

Closed gibbz00 closed 3 months ago

gibbz00 commented 4 months ago

See note about possibly changing the visibility of some helper methods to private . Leaving this as a draft until it is resolved 😊

https://github.com/tokio-rs/prost/blob/eff01566f2e6e759c1fb951b7c413ae16adcb4c8/prost-build/src/lib.rs#L150-L153

Depends on #1008.

caspermeijn commented 3 months ago

I already commented on the config split in #1020. I suggest doing the config and module split as two commits in a single PR.

gibbz00 commented 3 months ago

Oki, I think I'll just close both and redo this in a new PR. Think it will be easier to resolve new conflicts that way.