tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.69k stars 481 forks source link

prost-build: Split `Config` and `Module` into a separate module and files #1020

Closed gibbz00 closed 3 months ago

gibbz00 commented 4 months ago

PR contains a visibility question similar to #1015, which this PR builds upon,

gibbz00 commented 3 months ago

Hi!

I've now resolved the comments and combined the commit form #1015. I was first thinking about closing both in order to make sure that I wasn't overriding any new changes, but none had come in.

gibbz00 commented 3 months ago

I think that the failing CI clippy job was caused by https://github.com/tokio-rs/prost/pull/1014. It should probably be amended or fixed in a separate PR though. Might be worth denying failing CI jobs from getting merged.