search

tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.69k stars 481 forks source link

chore - codegen: `Syntax` to a separate file #1029

Closed gibbz00 closed 3 months ago

gibbz00 commented 3 months ago

Part of a series of module splits which became clear from #1026. Also functions as a way to improve the final reviewability of #1026.

gibbz00 commented 3 months ago

Why is a separated module better for such a small type?

I could inline the module in code_generator/mod.rs if you prefer. I like to avoid mixing domain models in the same module. Makes it easier to reason about visibility, dependencies and usage.

gibbz00 commented 3 months ago

Rebased and resolved comments!

caspermeijn commented 3 months ago

Thank you for your contribution