search

tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.77k stars 489 forks source link

Remove which dependency #962

Closed rukai closed 6 months ago

rukai commented 8 months ago

Rather than trying to predict if the OS will be able to find the binary before executing it we can just execute the binary and let the OS tell us if it found it or not. This is IMO more correct and lets us remove a dependency that required a rust version far above the projects MSRV.

LucioFranco commented 8 months ago

I will need to think about this change, in the meantime I think bumping the msrv is okay.

rukai commented 6 months ago

feedback should be all addressed now