search

tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.78k stars 489 forks source link

Bump itertools version to allow 0.12 #963

Closed jleibs closed 5 months ago

jleibs commented 8 months ago

Ran into a dependency conflict with using itertools 0.12 in our project that also depends on prost.

When I ran the tests everything appeared to work, so I'm not sure what the purpose of the <0.12 restriction was.

MarijnS95 commented 8 months ago

so I'm not sure what the purpose of the <0.12 restriction was.

It is never desired to publish crates with an unbounded upper version range, as there is no guarantee that future semver-breaking itertools crate releases are compatible with its use in this crate.

i.e. when this <0.12 clause was written in https://github.com/tokio-rs/prost/commit/4d55103f65b32440a5741a630bdfff011b546477, itertools 0.12 wasn't released yet.

This version-range model allows prost to publish patch releases with dependency bumps of itertools, after prost was tested to be compatible like you did in this PR :tada:

caspermeijn commented 5 months ago

Fixed in #948