search

tokio-rs / prost

PROST! a Protocol Buffers implementation for the Rust Language
Apache License 2.0
3.78k stars 489 forks source link

feat: add derive feature #992

Closed tottoto closed 5 months ago

tottoto commented 6 months ago

Related to #991.

tottoto commented 6 months ago

It would be good to document the features we publicly expose.

I think so too. However I think that it is out of scope from this pull request as there is not a document about features in the README (there is about no_std crates, but it is not a comprehensive document about features). I think it should be a separated concern. I think the scope should be minimum as possible.

caspermeijn commented 5 months ago

It would be good to document the features we publicly expose.

I think so too. However I think that it is out of scope from this pull request as there is not a document about features in the README (there is about no_std crates, but it is not a comprehensive document about features). I think it should be a separated concern. I think the scope should be minimum as possible.

I understand

tottoto commented 5 months ago
  • prost-types uses the old derive feature. I suggest replacing it:

Since it will be a breaking change or requires increasing dependent prost version, it is not recommended.

  • test-no-std uses the old derive feature. I suggest replacing it:

Updated.

caspermeijn commented 5 months ago

Thank you for your contribution