wip: basic sqlite driver implementation (using rusqlite)

tokio-rs / rdbc

Rust DataBase Connectivity (RDBC) :: Common Rust API for database drivers

Apache License 2.0

569 stars 25 forks source link

wip: basic sqlite driver implementation (using rusqlite) #21

Closed manuel-woelker closed 4 years ago

manuel-woelker commented 4 years ago

just a basic proof of concept, let me know if you have any comments

One thing I noticed is that it might make sense to change the signature of ResultSet::next(&mut self) -> bool to next(&mut self) -> Result<bool> to signal any errors cropping up during result set iteration

manuel-woelker commented 4 years ago

I just noticed you are currently working on resultset metadata, so this PR probably won't apply cleanly. I'll try to add that once the metadata API looks stablish.

andygrove commented 4 years ago

@manuel-woelker This is awesome! I've been blasting through a bunch of changes this morning direct to master ... I guess I should switch to PR model at this point.

I'm going to stop hacking now, so please let me know when this good to merge.