Use Box instead of Rc/RefCell

95th commented 4 years ago

Closes #43

andygrove commented 4 years ago

This is looking great!

Can you pull latest from master so that the github actions run.

When I run cargo test locally I get:

   Doc-tests rdbc-sqlite

running 1 test
test src/lib.rs -  (line 7) ... FAILED

failures:

---- src/lib.rs -  (line 7) stdout ----
error[E0599]: no method named `borrow_mut` found for type `std::boxed::Box<dyn rdbc::Connection>` in the current scope
 --> src/lib.rs:13:21
  |
9 | let mut conn = conn.borrow_mut();
  |                     ^^^^^^^^^^ method not found in `std::boxed::Box<dyn rdbc::Connection>`
  |
  = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
  |
3 | use std::borrow::BorrowMut;
  |

95th commented 4 years ago

@andygrove the doc tests weren't updated. pushed the updates now. The CI failed on todo macro saying it is unstable but it is stable. What version of rust is pinned for CI?

andygrove commented 4 years ago

I just pushed a commit to master to force the use of 1.40.0 ... could you try merging that ?

tokio-rs / rdbc

Use Box instead of Rc/RefCell #45