search

tokio-rs / tls

A collection of Tokio based TLS libraries.
https://tokio.rs
MIT License
253 stars 86 forks source link

Moving tokio-rustls into the rustls org? #138

Closed djc closed 1 year ago

djc commented 1 year ago

I think the grouping of tokio-rustls and tokio-native-tls in a single repo doesn't necessarily make as much sense today as it did in the past, since the shared tokio heritage is pretty stable and so the work is more closely bound to specific expertise in the TLS implementation. Given that the tokio-rustls is the 2nd most popular reverse dependency for rustls and as such an important way people consume rustls, I think it would make sense for tokio-rustls to live in the rustls GitHub org. I think we'd be happy to bring along any current maintainers who have been active on the crate (particularly @quininer of course, but others too if they want to).

What do people think? I could do the legwork of creating a new repo and populating it with the current history, then removing tokio-native-tls.

(Given the tight dependency mentioned above, we could even decide to move tokio-rustls into the rustls repository, as a sibling crate in the workspace.)

@ctz any thoughts?

LucioFranco commented 1 year ago

I think that is a great idea! I would also maybe like to see hyper-rustls get the same treatment?

djc commented 1 year ago

@quininer ping, any thoughts? @LucioFranco not sure what you mean, hyper-rustls already lives in the rustls org.

quininer commented 1 year ago

I have no problem with that.

ctz commented 1 year ago

@ctz any thoughts?

I like the idea, and for history-preservation reasons I think a separate repo would be preferable to filter-branching it into rustls/rustls.

djc commented 1 year ago

We can stitch it into multi-root repo to preserve the history without changing commits if you prefer, so that's not a good reason by itself to keep it in a separate repo.

djc commented 1 year ago

Starting with a separate repo, see https://github.com/rustls/tokio-rustls/pull/1. I've so far invited @quininer as a maintainer (in addition to existing rustls org admins) -- if any of the other maintainers here would like access, please let me know.

quininer commented 1 year ago

I'm temporarily unable to join this organization due to two-step verification requirements.

The last time I tried, github didn't allow me to just configure webauthn. I can try again sometime.

djc commented 1 year ago

@quininer let me know how that goes. I also regularly use the GitHub mobile app as a second factor, maybe that can work for you? (If you have a legitimate second factor and they somehow don't support it, maybe file a support request?)

quininer commented 1 year ago

@djc done.

djc commented 1 year ago

Next step in https://github.com/tokio-rs/tls/pull/146.

djc commented 1 year ago

This is pretty much done.

cpu commented 1 year ago

Thanks for implementing this @djc :heart: