Finalize tokio-service APIs for 0.1

tokio-rs / tokio-service

The core `Service` trait in Tokio and support

Apache License 2.0

82 stars 19 forks source link

Closed aturon closed 7 years ago

aturon commented 7 years ago

A bit of tidying up ahead of the 0.1 release:

Drop poll_ready for now, given that we're uncertain about the overall backpressure story, and it can be added easily as a defaulted method later on. Backpressure should be a major goal in an upcoming release.
Rename SimpleService to FnService, matching the Fn* traits.
Rename NewService::Item to NewService::Instance, for greater clarity about their relationship.

cc @carllerche @alexcrichton

alexcrichton commented 7 years ago

👍

carllerche commented 7 years ago

Seems good to me, we can revisit back pressure soon.

Kerollmops commented 7 years ago

up ? 😺

aturon commented 7 years ago

I've updated, now using FnService.

aturon commented 7 years ago

@alexcrichton Can you merge if/when you're happy with the final naming here?