search

tokio-rs / tokio-uring

An io_uring backed runtime for Rust
MIT License
1.11k stars 117 forks source link

Update README.md to improve wording #210

Open yerke opened 1 year ago

FrankReh commented 1 year ago

@Noah-Kennedy I think we know by now that if the README is going to recommend a kernel, it should either say uring kernel feature development and bug fixing has gone well into the 6.1 kernel or it should say the user of this crate should check with the uring status of the kernel they are trying to target. Calling out any old kernel version explicitly sounds like the crate author is making a recommendation on what minimal kernel will work.

Noah-Kennedy commented 1 year ago

@FrankReh I'm in complete agreement here

yerke commented 1 year ago

Do you want me to update the wording in this PR somehow? Or should I just close it and let me you handle it separately? Thanks.

FrankReh commented 1 year ago

I suggest you leave this open and we can treat it as an open Issue. I think Noah will change the README at some point and this can then be closed. Thanks for wanting to help. At this point, it's better to leave an old comment as it should be pretty evident it is an old/obsolete recommendation.