search

tokio-rs / tokio-uring

An io_uring backed runtime for Rust
MIT License
1.11k stars 117 forks source link

feature: add support for flags in function write_at #305

Open kz2d opened 3 months ago

kz2d commented 3 months ago

Hi. I need support for flags in write operation, and implemented it in this PR.

PR implement struct for flags and don't implement all flags.
And then pass this flags on write.

Currently I haven't added tests, so if code is alright I would like too add tests.

ileixe commented 3 months ago

You don't have to add new API for setting flag as it can be added in Unsubmit struct.

But if it's added in there, I found exposing flag to user may lead to unsafe behavior (e.g. linked op should be submitted at once). So I think here, we at least make the set_flag API unsafe.

kz2d commented 3 months ago

Hi I have added options to set flags on UnsubmittedOneshot like you have said and made it unsafe.

kz2d commented 2 months ago

Hi, can you look at PR, please.

kz2d commented 2 months ago

Hi. Any help here?

ileixe commented 2 months ago

Hm.. unfortunately, I think nobody currently maintains this repo for now. @ollie-etl is the only one that I know responding. Any advice ollie?

ollie-etl commented 2 months ago

I've the same frustration. The repo is dead, as far as I can tell