search

tokio-rs / tokio

A runtime for writing reliable asynchronous applications with Rust. Provides I/O, networking, scheduling, timers, ...
https://tokio.rs
MIT License
26.59k stars 2.45k forks source link

doc: Fix a symbol issue #6852

Closed vxzyfx closed 2 weeks ago

vxzyfx commented 2 weeks ago

Motivation

There is a punctuation error.

Solution

Change “socket hijacking” to "socket hijacking".

jofas commented 2 weeks ago

punctuation error

Just a nit, but the currently used quotation marks are known as smart quotes. Given that the comment is written in English prose, I wouldn't say they are erroneously used from a typographical perspective (albeit it's rare to see them actually typed out, given that they are non-trivial to type on a QWERTY keyboard). So the question of whether one should use smart quotes or non-smart quotes here boils down to a matter of taste—rather than right or wrong—IMO.

vxzyfx commented 2 weeks ago

Thank you for your explanation.

jofas commented 2 weeks ago

My comment wasn't meant to be a rejection of your PR, I was just trying to contribute to the discussion. Whether your PR is an enhancement to the Tokio docs or not is not my decision to make. If you closed your PR just because of my comment, please reopen it and let the maintainers decide whether they want to merge this or not.