search

tokio-rs / tracing

Application level tracing for Rust.
https://tracing.rs
MIT License
5.39k stars 707 forks source link

chore: new clippy/rust lints #2948

Closed dpc closed 5 months ago

dpc commented 5 months ago

Motivation

clippy is failing with recent Rust toolchain up to 1.77.2.

Solution

Give clippy what it wants.

hds commented 5 months ago

@dpc there's one more failure in clippy still: https://github.com/tokio-rs/tracing/actions/runs/8789287064/job/24141292737?pr=2948

hawkw commented 5 months ago

The remaining clippy failure (https://github.com/tokio-rs/tracing/actions/runs/8807729140/job/24205123089?pr=2948#step:4:825) should probably be solved with an allow attribute; I believe the Arc is being used to track when the struct is dropped, so it's okay that we don't actually read its value.