search

tokio-rs / valuable

MIT License
185 stars 19 forks source link

derive: implement #[valuable] attributes #75

Closed taiki-e closed 3 weeks ago

taiki-e commented 2 years ago

The first step for #51.

(This commit was created about 5 months ago. However, I didn't open the PR at the time because something was missing, but I don't remember what it is anymore, so I'll open the PR as a draft anyway.)

rwestphal commented 2 years ago

Would love to see this getting added!

fosskers commented 2 months ago

Any news on this?

johnhurt commented 3 weeks ago

Hey, I'm not sure why this pr stalled out, but I really like the functionality and the way you've written it. I am going to try to push it forward. I added a new pr that duplicates the work you did here (and rightly attributes authorship to you). My pr also includes a macro attribute for formatting a field for including a simplified version of a field when the field's type doesn't implement Valuable. Thanks for your work here! I hope we can get it included in the actual codebase.