Closed hawkw closed 2 years ago
Hmm. It looks like this was merged into #89 after #89 was merged into master.
Hmm. It looks like this was merged into #89 after #89 was merged into master.
Whoops...normally, I thought GitHub rebases branches onto master
when the base branch merges, so I expected that to happen here...
@taiki-e opened #92 with the correct base branch, sorry about that!
Depends on #89
This PR changes
valuable-serde
's recording ofdyn Error
values to record the error as aserde
struct withmessage
andsource
fields. This way, we can serialize errors with source chains more nicely.When the backtrace support for
std::error::Error
is stable, we could also record backtraces as a field. We could even consider adding a build script to detect the nightly compiler and conditionally enable acfg
for backtrace support, but that seems better left to a follow-up.