tokio-rs / website

Website for the Tokio project
https://tokio.rs
MIT License
229 stars 329 forks source link

Added a small explanation of a change to Bytes #666

Closed jv-garcia closed 2 years ago

jv-garcia commented 2 years ago

The "Update process()" section mentions that we indeed need to pass the HashMap as an argument. As I was going through those changes, the change from Vec<u8> to Bytes went under my radar (needs a change in line 138), and although it's simple enough to detect, I thought it would make sense to include this short explanation.

How did I test this?

Ran the indicated tests in the README.md locally:

# in doc-test
cargo +nightly test

# in tutorial-code
cargo test --all

Do notice that the doc tests required me to run with RUSTFLAGS="--cfg tokio_unstable", I can update the README as well to reflect this change if that's OK.

Darksonn commented 2 years ago

Thanks!