tokio-rs / website

Website for the Tokio project
https://tokio.rs
MIT License
228 stars 329 forks source link

added dark mode support #701

Open stanwolverine opened 1 year ago

stanwolverine commented 1 year ago

Hello everyone,

I'm excited to share this PR for adding dark theme support. Please visit the preview, I would really appreciate your feedback and suggestions. You can also suggest some better colors for the dark theme. I'd also like to know if there are any UI elements where the dark theme changes have not been applied or any other feedback, I'm all ears.

Thank you so much for taking the time to review my PR and provide your insights. I look forward to hearing your thoughts!

Pending actions on this PR:

Darksonn commented 1 year ago

How do I get my browser to switch to dark mode?

stanwolverine commented 1 year ago

@Darksonn If you "turn on" dark theme on your device, then website will also switch to dark mode

stanwolverine commented 1 year ago

for example, on macOS you can use highlighted option in image:

Screenshot 2023-04-30 at 2 06 35 AM
hawkw commented 1 year ago

Looks nice on my machine, at least! image

stanwolverine commented 1 year ago

@hawkw also checkout docs and code snippets

Darksonn commented 1 year ago

Sure, this sounds good to me. I would be happy to merge this. Did you have any further changes you wanted to get in before I do so?

stanwolverine commented 1 year ago

@Darksonn let me add a button to toggle theme, then we can merge it

stanwolverine commented 1 year ago

Hey @Darksonn, You can review and merge this PR now if everything looks good

Darksonn commented 1 year ago

I tried clicking the button on this page, but the area to the right of the page remains white. See the screenshot below.

Screenshot

stanwolverine commented 1 year ago

I tried clicking the button on this page, but the area to the right of the page remains white. See the screenshot below.

Screenshot

@Darksonn fixed this