search

tokland / arch-bootstrap

Bootstrap a base Arch Linux system
312 stars 89 forks source link

Add arch support for ARM variants #17

Closed gevans closed 8 years ago

gevans commented 8 years ago

$ARCH comparisons now check for strings beginning with arm. This allows bootstrapping with specific ARM architectures in mind:

arch-bootstrap -q -a armv7h target

Previously, this would have failed due to the use of the wrong repository mirror and non-existent qemu-user-static binary.

yannayl commented 8 years ago

I already stated my feelings regarding the 'X' prefix in the string comparison (I don't see any reason not to have it).

But otherwise looks good to me. Nice work :+1:

IwilI try to test it later on tonight.

gevans commented 8 years ago

Thanks for looking it over. Let me know if you run into any issues. :)

I still think that prefixing in bash scripts is more of a bad habit than a code style but I'll let @tokland make the final judgment on that.

yannayl commented 8 years ago

working. good job :+1:

after looking at the file as a whole (not only the online diff in github), I agree with your inversion of conditions in the 'if' statement, it is more readable. I think it deserves it's own commit, though.

p.s. what about aarch64? unfortunately, the static arm qemu from the ubuntu repo does not support it well (illegal instruction - core dump). I saw it also needed an additional package: nettle. probably a missing dependency of pacman or something. anyway... maybe in the future.

gevans commented 8 years ago

Thanks for testing it out. I'll reverse those if-statements in a separate commit later tonight.

gevans commented 8 years ago

@tokland: This pull request is ready for you to review and merge.

tokland commented 8 years ago

Merged, thanks guys!