search

toko-bifrost / ms-teams-deploy-card

Microsoft Teams Deploy Card
MIT License
96 stars 77 forks source link

Action with failed step still showing as success #13

Closed Shaun-Harrison closed 4 years ago

Shaun-Harrison commented 4 years ago

Hello

I guess there may be two issues here

Firstly, I noticed that my action has failed on a previous step, because of this the Teams message step wasn't ran at all, to say if it had succeeded or failed, so I added if: always() to the step. This then got the teams message to post regardless of previous steps failing, but the result in the teams message still said success although a step failed

image

AdamHansrod commented 4 years ago

I think this is the same issue I had that led me to suggest the 'show-on-failure' feature

aldwyn-acn commented 4 years ago

Hi @Shaun-Harrison. Version 3.1.0 have been released and kindly refer to the Known Issues in the docs. Thank you.