Show Card on Failure is resulting in a card for skipped jobs

[dakota-maker-by]

Hi there,

My team has been using this library now for a little bit and the cards have been working great, but we are getting some unexpected behavior from the show-on-failure property, which is showing cards when the job has skipped. I definitely get the idea behind skipped not being success, but given the name I think show-on-failure should only show for failed builds

setup:

- name: Publish Automerge Failure Card
  uses: toko-bifrost/ms-teams-deploy-card@3.1.2
  if: always()
  with:
      github-token: ${{ secrets.pat }}
      webhook-uri: ${{ secrets.uri }}
      show-on-start: false
      show-on-failure: true

[aldwyn-acn]

Hi @dakota-maker-by, could you please use the one in branch release/v3 and tell me what you see on the post-action logs? Thanks.

[aldwyn-acn]

As there are no updates on this issue in at least a month, I'm closing this for now.

[Shaun-Harrison]

Hello

I've encountered this issue today using version ms-teams-deploy-card@3.1.1

For me it's happening with multi job builds

Although the jobs are showing as completed successfully the card if reporting a skipped status

[Shaun-Harrison]

Is there any news on this please @aldwyn-acn

[aldwyn-acn]

Hey @Shaun-Harrison, I'll work on this over the weekend. Thanks for the heads-up.

[oshdev]

We're encountering the same issue. In our case, the job is success, but it shows as skipped.

In the setup we have some e2e tests as a second to last test, and the very last step is a conditional to upload tests artefacts if the e2e fails, so the last step will always be skipped on a successful job run.