Show cards logic issue

[uncledru]

Setting both show-on-exit and show-on-failure sets the configuration to not show card upon job exit. See images below.

The issue seems to lie somewhere here

I can contribute if needed :)

[aldwyn-acn]

Hi @uncledru, I've made clear in the README the following descriptions 😁

| show-on-exit | false | true | Show an MS Teams card upon exiting this Github Actions job, regardless if it's a successful or a failed exit | | show-on-failure | false | false | Show an MS Teams card upon exiting this Github Actions job and status is FAILURE; This will override any boolean value of show-on-exit, e.g. with show-on-exit=false and show-on-failure=true, the notification card will still proceed upon job failure |

[uncledru]

Got it. Thanks @aldwyn-acn! If I'm understanding correctly -- I need to set show-on-exit to false and show-on-failure to `true

to get both failure and success notifications on exit?

[aldwyn-acn]

@uncledru to get both failure and success notifications on exit, you only have to set show-on-exit to true. Or don't set any value on it at all because its default is already true. Don't mind setting the show-on-failure.

[uncledru]

Awesome. Thank you! Loving the action :)