search

tokopedia / RxComposableArchitecture

RxComposableArchitecture is a forked of Composable Architecture with adjustment to make it work with UIKit.
Apache License 2.0
31 stars 5 forks source link

Cancel key will cancel all Effect Even with Different Store #32

Open jeffersonsetiawan opened 2 years ago

jeffersonsetiawan commented 2 years ago

It's because the Effect cancellation is stored in the global internal var cancellationCancellables: [AnyHashable: Set<AnyDisposable>]

Discussed on this PR discussion

Tokopedia is using separate Store for every page/feature, so problem will happen in the future.

ivanbagaskara commented 2 years ago

will pick this up after finishing these two: