search

tokopedia / RxComposableArchitecture

RxComposableArchitecture is a forked of Composable Architecture with adjustment to make it work with UIKit.
Apache License 2.0
31 stars 5 forks source link

Vendored Dependencies #88

Closed adityadaniel closed 1 year ago

adityadaniel commented 1 year ago
jeffersonsetiawan commented 1 year ago

Let's use pointfree's Dependency and rename RxSwift mainQueue to something like: rxMainQueue

dikasetiadi commented 1 year ago

Nil @adityadaniel, with this improvement, some of our code like TestStore (eg: on the init we have mechanism to override dependency in there) are still using old implementation, does this breaking the code in there?

our current code changes: https://github.com/tokopedia/RxComposableArchitecture/blob/197edf2054917716654827607678fd9927451269/Sources/RxComposableArchitecture/TestSupport/TestStore.swift#L684

source for new changes: https://github.com/pointfreeco/swift-composable-architecture/blob/23501d36a7ec19e8c842c3eaa851d0c1534c3d88/Sources/ComposableArchitecture/TestStore.swift#L668

adityadaniel commented 1 year ago

Nil @adityadaniel, with this improvement, some of our code like TestStore (eg: on the init we have mechanism to override dependency in there) are still using old implementation, does this breaking the code in there?

our current code changes:

https://github.com/tokopedia/RxComposableArchitecture/blob/197edf2054917716654827607678fd9927451269/Sources/RxComposableArchitecture/TestSupport/TestStore.swift#L684

source for new changes: https://github.com/pointfreeco/swift-composable-architecture/blob/23501d36a7ec19e8c842c3eaa851d0c1534c3d88/Sources/ComposableArchitecture/TestStore.swift#L668

Should not breaking anything @dikasetiadi since all the CI is already green, but let me try to adjust using latest version ya