tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
98 stars 65 forks source link

Problem of "PL_files" #142

Closed kobalab closed 10 years ago

kobalab commented 10 years ago
  1. If you use TOML 0.93 or later, syntax error occurs.
  2. If you write lib/Hoge.pm.PL="lib/Hoge.pm", lib/Hoge.pm.PL can't get parameter lib/Hoge.pm.
tokuhirom commented 10 years ago

@karupanerura ↑↑ how do you think this? Is this behaviour a spec?

karupanerura commented 10 years ago

I think it is TOML's bug. TOML.pm has incompatible changes int 0.93. But this is not what I intended. I fixed this issue at commit baa4e41. And I released TOML 0.95 containing this fix. Please use this version (or later).

NOTE: Key name format are not strictly defined in spec.

kobalab commented 10 years ago

I tried TOML-0.95, problem 1 fixed, thanks. but I think problem 2 remains yet. please fix it.

tokuhirom commented 10 years ago

Is there a sample code for reproduce this issue?

kobalab commented 10 years ago

See https://github.com/kobalab/Foo-Bar/blob/master/lib/Foo/Bar/Env.pm.PL

original code is my $pm_file = shift;, but don't work. I rewrite this as my $pm_file = 'lib/Foo/Bar/Env.pm';.

otherwise, see http://d.hatena.ne.jp/xlc/20141009/1412784976

miyagawa commented 10 years ago

I'm not sure if Minilla has anything to do with PL_files, it seems to pass these options to Module::Build. Maybe you should change the module_maker to Module::Build? I guess the default builder ::Tiny doesn't support PL_files.

miyagawa commented 10 years ago

Here's the part where Module::Build::Tiny runs *.PL to generate pm. https://github.com/Leont/module-build-tiny/blob/master/lib/Module/Build/Tiny.pm#L84

I'm not sure if it's intentional but if you really care about the bug fixed on the MBTiny, you should report there as an upstream bug.

miyagawa commented 10 years ago

@kobalab Module::Build::Tiny does support PL files, but it's not compatible to what MakeMaker/MB does in terms of its invocation. It would be trivial to patch MBTiny to support passing the filenames.

kobalab commented 10 years ago

@miyagawa Thanks. I'm using ModuleBuild as module_maker now.

Leont commented 10 years ago

It was an oversight in Module::Build::Tiny, it has been fixed now.