tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
98 stars 65 forks source link

Work with ssh:// scheme #145

Closed lestrrat closed 10 years ago

lestrrat commented 10 years ago

For watever reason, when I clone my repositories I get a repository url qualified with the ssh:// scheme, which Minilla doesn't seem to expect:

   url = ssh://git@github.com/lestrrat/Data-Localize.git

This creats all sorts of havoc in the META.json resources section:

   "resources" : {
      "bugtracker" : {
         "web" : "https://ssh///git@github.com/lestrrat/Data-Localize/issues"
      },
      "homepage" : "https://ssh///git@github.com/lestrrat/Data-Localize",
      "repository" : {
         "type" : "git",
         "url" : "git://ssh///git@github.com/lestrrat/Data-Localize.git",
         "web" : "https://ssh///git@github.com/lestrrat/Data-Localize"
      }
   },

This change fixes this by checking for the ssh:// scheme when stripping git@ username from github repository URLs

lestrrat commented 10 years ago

hmm, there seems to be a bit more fixing needed... will update soon.

tokuhirom commented 10 years ago

Closed by #146