search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

Push '.' to @INC when custom builder is used #216

Closed syohex closed 7 years ago

syohex commented 7 years ago

@INC does not contain current directory from Perl 5.25.9. This is related to #215.

skaji commented 7 years ago

I have confirmed that with this change, perl compiled with -Ddefault_inc_excludes_dot could configure/build/test/install Compiler-Lexer and Hash-FieldHash.

toddr commented 7 years ago

I don't think this will fix it. I think this is going to require PERL_USE_UNSAFE_INC but I'll need to test it later. If I could see a Build.PL generated from this, I could tell you if it works. I'll see if I can figure out how to re-generate the one for Mouse.

syohex commented 7 years ago

Thanks for comments. I'll see them later.

skaji commented 7 years ago

LGTM

@toddr Could you test this please?

toddr commented 7 years ago

@skaji Minilla now builds the correct Build.PL for Mouse. Once this is merged and released, I'll let the 5 dists that need a new Build.PL to update Minilla and release.

syohex commented 7 years ago

Thanks for reviewing. I have merged.