search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

minor fix: do not count file:// repository as github #246

Closed skaji closed 6 years ago

skaji commented 6 years ago

I develop Minilla in ~/src/github.com/tokuhirom/Minilla directory. Then running test emits a lot of warnings:

❯ prove -l t/cli/regenerate_BuildPL.t
t/cli/regenerate_BuildPL.t .. Use of uninitialized value $user in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 510.
Use of uninitialized value $repo in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 510.
Use of uninitialized value $user in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 511.
Use of uninitialized value $repo in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 511.
Template error: Use of uninitialized value $user in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 510.
Template error: Use of uninitialized value $repo in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 510.
Template error: Use of uninitialized value $user in concatenation (.) or string at /home/skaji/src/github.com/tokuhirom/Minilla/lib/Minilla/Project.pm line 511.
...

This is because file://~/src/github.com/tokuhirom/Minilla is regarded as "github url". I do not think we should count file:// as github url.